sunxi: Fix gmac not working reliable on the Bananapi

In order for the gmac nic to work reliable on the Bananapi, we need to set
bits 10-12 GTXDC "GMAC Transmit Clock Delay Chain" of the GMAC clk register
(0x01c20164) to 3.

Without this about 9 out of 10 ethernet packets get lost, with this setting
there is no packet loss.

So far setting these bits is only necessary on the Bananapi, so this commit
solves this with a bit of #ifdef CONFIG_BANANAPI code. If in the future we
need to do something similar for other boards, we can create a specific
CONFIG_FOO option for this then.

Reported-by: Karsten Merker <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
Tested-by: Karsten Merker <[email protected]>
Tested-by: Zoltan HERPAI <[email protected]>
Tested-by: Tony Zhang <[email protected]>
Acked-by: Ian Campbell <[email protected]>

diff --git a/board/sunxi/gmac.c b/board/sunxi/gmac.c
index e7ff95285c97be8e816e2c31a8e739dd91c861db..6348d27282748d66cf6d55f484fdefa69d4a0af6 100644 (file)
--- a/board/sunxi/gmac.c
+++ b/board/sunxi/gmac.c
@@ -24,6 +24,15 @@ int sunxi_gmac_initialize(bd_t *bis)
                CCM_GMAC_CTRL_GPIT_MII);
 #endif
 
+       /*
+        * In order for the gmac nic to work reliable on the Bananapi, we
+        * need to set bits 10-12 GTXDC "GMAC Transmit Clock Delay Chain"
+        * of the GMAC clk register to 3.
+        */
+#ifdef CONFIG_BANANAPI
+       setbits_le32(&ccm->gmac_clk_cfg, 0x3 << 10);
+#endif
+
        /* Configure pin mux settings for GMAC */
        for (pin = SUNXI_GPA(0); pin <= SUNXI_GPA(16); pin++) {
 #ifdef CONFIG_RGMII